Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ganglia_port default to string #32

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Change ganglia_port default to string #32

merged 1 commit into from
Dec 10, 2014

Conversation

NoodlesNZ
Copy link
Contributor

I looked at trying to validate ganglia_port as an integer for future parser, but it all seemed a bit hacky. I've changed the default to a string, this way it will work with both parsers. If people are using the current parser then passing in a bareword port number will still work.

@jhoblitt
Copy link
Owner

jhoblitt commented Dec 2, 2014

I apologize for the slow response -- last week was a holiday week in the US.

Did you try a strategy similar to this?

https://github.com/puppetlabs/puppetlabs-concat/blob/master/manifests/fragment.pp#L43-L45

If that doesn't work for some reason I'm happy to merge this.

@NoodlesNZ
Copy link
Contributor Author

That looks like it might work. I'll look at adding some rspec tests for web later

jhoblitt pushed a commit that referenced this pull request Dec 10, 2014
Change ganglia_port default to string
@jhoblitt jhoblitt merged commit d8d443a into jhoblitt:master Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants