Fix problem with undef override_hostname #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no rspec tests as part of this PR? |
|
Yea, I failed at writing the rspec test. I wanted it to fail if override_hostname is present with the default params. |
|
Well, it's failing... |
|
Ok, that seems to have got it (with the Travis CI problem again). |
|
#36 should work around the ruby 1.8.7 problem. Try rebasing on top of master. |
|
Looks like #36 did the trick, good work |
|
Could you rebase? |
|
@NoodlesNZ ping? This PR needs to be rebased so it can be merged. |
|
I've only just got back from vacation, so will look at this once I've caught up on emails/work. |
|
There you go, that should do it. |
jhoblitt
pushed a commit
that referenced
this pull request
Jan 21, 2015
Fix problem with undef override_hostname
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If override_hostname is not defined it uses the default of undef, but the logic in the template doesn't work as expected. I've added a failing rspec test first, which I will fix in another commit.