Ubuntu port

[kitchen]

this PR ports the module to ubuntu.

[jhoblitt]

Debian/Ubuntu support has been on my mental todo list forever, thank you for working on this!

On first glance, I'm OK with everything in this PR but I'd like to add a few basic rspec-system tests before merging it; I'll take an action item to do that.

Could you fix up the rspec-puppet tests? The tests in this module really need some TLC.

[jhoblitt]

Just to clarify, I'm only asking for the test failure to be resolved -- a test overhaul ;)

[kitchen]

oh, hrm. I didn't even see the tests (I could have sworn I even looked!)

I'll fix that up for sure.

Also, I just realized that the gmetad init script also does not have status support so I'll add that to the PR as well in a bit.

Thanks!

[kitchen]

and it looks like the status command bit has been fixed going forward (at least in 13.04) so I'll check and support that as well.

[kitchen]

ok, should be ready to go again!

[kitchen]

I checked the init script on 12.04, 12.10, and 13.04. 13.04 is when the status command comes in.

[jhoblitt]

Still has a travis failure.

[jhoblitt]

This expression is causing a test failure with ruby 1.8.7 because the fact isn't declared; should be an easy fix. It would also be better to use $::operatingsystemmajrelease as that's a core fact not dependent on having an lsb package installed. If lsb* facts have to be used a module level dep on http://forge.puppetlabs.com/razorsedge/lsb should be introduced.

[kitchen]

That's odd. It is declared on my ubuntu systems, whereas $::operatingsystemmajrelease is not.

[kitchen]

yay, build passes now!

[jhoblitt]

Looks like I dropped the ball on this -- it's looks good now! I'm planning to merge it as soon as I find a few minutes to add rspec-system tests to the system with a ubuntu box.

[jhoblitt]

I apologize again for taking so long on this. I finally found the time to properly test this and extend the trivial rspec-puppet test coverage to ubuntu. I plan to cut a 1.1.0 release shortly.

[kitchen]

Rawr! Thanks :) sorry I've been quiet on this I actually switched to new relic so haven't had a direct interest to do some active development :) happy holidays!

-Jeremy

Insert PGP signature here.

On Dec 20, 2013, at 4:46 PM, Joshua Hoblitt notifications@github.com wrote:

I apologize again for taking so long on this. I finally found the time to properly test this and extend the trivial rspec-puppet test coverage to ubuntu. I plan to cut a 1.1.0 release shortly.

—
Reply to this email directly or view it on GitHub.