gmetad.conf - adding support for managing 'all_trusted' and 'trusted_hos...

[tskirvin]

...ts'

Adds two optional parameters to gmetad.pp - 'all_trusted' (a boolean,
default false), and 'trusted_hosts' (array of strings, default empty).
These can be used to populate the corresponding fields in gmetad.conf.

Includes a spec file check for these parameters as well, though I haven't
tested that adequately yet.

[jhoblitt]

This causes failures under the future parser (which are allowed to fail in the travis matrix due to a change in erb :undef handing) -- could you add a condition check for nil and check the output of the future parser runs?

[tskirvin]

Joshua Hoblitt notifications@github.com writes:

@@ -102,12 +102,16 @@ gridname "<%= scope.lookupvar('::ganglia::gmetad::gridname') %>"

is always trusted.

default: There is no default value

trusted_hosts 127.0.0.1 169.229.50.165 my.gmetad.org

+trusted_hosts <%= @trusted_hosts.join(' ') %>

This causes failures under the future parser (which are allowed to fail
in the travis matrix due to a change in erb :undef handing) -- could
you add a condition check for nil and check the output of the future
parser runs?

    I've added the condition check for nil?, along with some other

checks. I'm running into an issue with the .spec bit for a block like
this, though:

context 'default' do
it 'should have an empty trusted_hosts' do
should contain_file('/etc/ganglia/gmetad.conf').
with_content(/^# trusted_hosts .*$/)
end
end # default

    It's complaining like the 'trusted_hosts' block can't be parsed,

but I'm really not sure why. I've left it commented out for now; the
checks are still fairly useful but not as good as I'd like.

    As for the future parser, it's still griping, but apparently based

on something to do with case_sensitive_hostnames.

    I'm happy to take another round at this if you think I can help.

                       - Tim Skirvin (tskirvin@killfile.org)

http://wiki.killfile.org/ Skirv's Homepage < <*>
http://www.flickr.com/photos/tskirvin Skirv's Pictures

[tskirvin]

Joshua Hoblitt notifications@github.com writes:

@@ -102,12 +102,16 @@ gridname "<%= scope.lookupvar('::ganglia::gmetad::gridname') %>"

is always trusted.

default: There is no default value

trusted_hosts 127.0.0.1 169.229.50.165 my.gmetad.org

+trusted_hosts <%= @trusted_hosts.join(' ') %>

This causes failures under the future parser (which are allowed to fail
in the travis matrix due to a change in erb :undef handing) -- could
you add a condition check for nil and check the output of the future
parser runs?

    Okay, I think I have it working the way you'd expect: 

https://github.com/jhoblitt/puppet-ganglia/pull/48

    The CI build passes, the only errors associated with

Jenkins appear to be associated with 'gridname' in gmetad.conf and
'override_hostname' in gmond.conf (neither of which I touched).

                       - Tim Skirvin (tskirvin@killfile.org)

http://wiki.killfile.org/ Skirv's Homepage < <*>
http://wiki.killfile.org/software/ Skirv's Software

[tskirvin]

Should be good to go now. The future parser is still griping, but not about changes I made (as far as I can tell).

[jhoblitt]

Thank you for putting effort into this!

I believe it was complaining before this PR about a change in undef behavior inside of ERB that I haven't fuly run down (I think it happened around 3.7.1). I'll merge this today after an acceptance test run.

[jhoblitt]

Also, would you add the the new params to the README? Hopefully, we'll be living in the future were the puppet docs are marchine generated soon but we're not there yet.

[tskirvin]

Joshua Hoblitt notifications@github.com writes:

Also, would you add the the new params to the README? Hopefully, we'll
be living in the future were the puppet docs are marchine generated soon
but we're not there yet.

    Done.

                       - Tim Skirvin (tskirvin@killfile.org)

http://wiki.killfile.org/ Skirv's Homepage < <*>
http://www.facebook.com/tskirvin Skirv's Social Networking

[jhoblitt]

It passed an acceptance test run. Thank you for contributing!