Fixed conf.php for current ganglia web #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NoodlesNZ This looks good. I discovered this myself right after I cut the 2.0.0 release and wasn't sure what to do about it. Do you think this should be a major version bump or 2.1.0? |
jhoblitt
pushed a commit
that referenced
this pull request
Aug 27, 2015
Fixed conf.php for current ganglia web
|
Thanks for that @jhoblitt . Probably just a 2.1.0 release, if you can hold off I'll push another PR today to add rrdcached socket into ganglia web (something I had to add recently as RRD was killing my ganglia box). |
|
@NoodlesNZ Sure - no rush on my part. |
|
Release as v2.1.0: https://forge.puppetlabs.com/jhoblitt/ganglia/2.1.0 |
|
Doh, I forgot about this. Thanks for the release Josh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for conf.php. I'm not sure if it's worth copying all of the options over from the default_conf.php as it means keeping the template up to date with any changes.