Set puppetversion in the facts for rspec tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis glitch? I've restarted the build. |
|
It worked on the rebuild. Thank you! |
jhoblitt
added a commit
that referenced
this pull request
Feb 24, 2016
Set puppetversion in the facts for rspec tests
|
@jthiltges Merged as #65 (rebased on master after the merge of #64). Thank you for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some discussion of the "'versioncmp' parameter 'a' expects a String value, got Undef" error: https://tickets.puppetlabs.com/browse/PUP-5683
Passing the Puppet.version parameter along in the facts appears to resolve the error. The tests should probably also be expanded to validate the cases where puppetversion is used in the manifests.