PDK Convert & Some tests passing on Puppet 6 #84
Conversation
|
I really appreciate the effort that's going into this PR. Could someone explicitly ping me when it is ready for merge in case I miss the title being updated? |
|
@jhoblitt no problem, just pinging you now that all tests pass! Quite welcome on the effort. EDIT: Solved the older EL5 version issues |
frizop
changed the title
|
Alright, I think that's it. @jhoblitt I did end up doing some more to the module to clean things up like added So I just pushed up a cherry-pick to make sure that it is contained in the repo. Apologies for that. |
|
I would be fine with making a major version bump and dropping anything older than rhel/centos 7. |
|
@frizop I'll take a detailed look once CI passes. Could I ask you to do a rebase to remove the merge commit? |
Sure thing. Give me a minute and I'll push that up |
|
Sadly I had to force push again because that merge got involved. Let me know if this looks good for you @jhoblitt |
- pdk validate -a run after all code changes to verify (and it fixed a bunch of stuff) - accidentally removed travis (which is needed for our external testing) - type: :rvalue was required for functions that return data - Re-added EL5 support, tests also pass now There's for sure a good reason to upgrade functions to a newer puppet compatibility version https://puppet.com/docs/puppet/5.5/functions_ruby_overview.html Fixup for metadata.json
|
This looks great. Thank you for putting all the effort into this! |
No description provided.