Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #88

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Small fixes #88

merged 1 commit into from
Sep 10, 2020

Conversation

frizop
Copy link
Collaborator

@frizop frizop commented Sep 10, 2020

  • params need the $ to show up for yard to pick them up
  • we're using travis for builds so we don't need gitlab-ci
  • including the github_changelog_generator for upcoming pdk release

jhoblitt
jhoblitt reviewed Sep 10, 2020
View reviewed changes
manifests/gmetad.pp Outdated Show resolved Hide resolved
@jhoblitt
Copy link
Owner

Could you rebase?

Small fixes
b47c64f 
- params need the \$ to show up for yard to pick them up
- we're using travis for builds so we don't need gitlab-ci
- including the github_changelog_generator for upcoming `pdk release`
- Update to using the style `@param PARAM_NAME` without data type
@frizop
Copy link
Collaborator Author

frizop commented Sep 10, 2020

Squashed and rebased to a single commit. Should be safe to merge when checks pass.

@jhoblitt jhoblitt merged commit c7f9027 into jhoblitt:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frizop @jhoblitt