Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to EL8 defaults #94

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Updates to EL8 defaults #94

merged 1 commit into from
Feb 19, 2021

Conversation

frizop
Copy link
Collaborator

@frizop frizop commented Nov 30, 2020

  • new param globals_user
  • new param globals_max_udp_msg_len
  • gmond.conf.debian.erb now makes me think EL defaults look the same
  • templates/gmond.conf.el6.erb also makes me think we could settle on a single template
  • default user now ganglia as class param, and in testing
  • spec updates for checking the content of our new params

Updates to EL8 defaults
4000d8a 
- new param globals_user
- new param globals_max_udp_msg_len
- gmond.conf.debian.erb now makes me think EL defaults look the same
- templates/gmond.conf.el6.erb also makes me think we could settle on a single template
- default user now ganglia as class param, and in testing
- spec updates for checking the content of our new params
@frizop
Copy link
Collaborator Author

frizop commented Nov 30, 2020

I know you had a few issues with blacksmith @jhoblitt in the past, but I'll leave it up to you if you want to bump a version. I'll be happy to do so if you have any notes on specifically what you did. Thanks!

@jhoblitt jhoblitt self-requested a review November 30, 2020 20:03
jhoblitt
jhoblitt approved these changes Nov 30, 2020
View reviewed changes
Copy link
Owner

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jhoblitt
Copy link
Owner

@frizop A release should be just a question of merging a PR that bumps the version in metadata.json then pushing a tag into thr repo... assuming travis is working today...

@jhoblitt jhoblitt merged commit 1ba486c into master Feb 19, 2021
@jhoblitt jhoblitt deleted the el8_updates_and_params branch February 19, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frizop @jhoblitt