Fact has a few issues

[petems]

Use of backticks means command will be run on all systems

This should be switched to Facter.exec

Use Facter.which for checking if present

Similar to the backtick usage, there is a Facter.which helper which can help here

Break loop for ipmi not running on channel 1 doesnt seem to work

My IPMI is running on channel 2:

root@homebox:~# ipmitool lan print 1
Invalid channel: 1

root@homebox:~# ipmitool lan print 2
Set in Progress         : Set Complete
Auth Type Support       :
...

The fact only runs if I change the channel_nr to 2:

channel_nr = 2
while true
  break unless IPMIChannel.new(channel_nr).load_facts
  channel_nr += 1
end

  ipmi2_gateway: 192.168.0.1
  ipmi2_ipaddress: 192.168.0.37
  ipmi2_ipaddress_source: DHCP Address
  ipmi2_macaddress: 3c:a8:2a:9f:9a:92
  ipmi2_subnet_mask: 255.255.255.0

PR incoming! 😄