Support for ipmievd. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some how I missed the notification email for this PR. This looks great. |
|
@razorsedge I added some validation of the |
mojothemonkey
added a commit
to mojothemonkey/puppet-ipmi
that referenced
this pull request
Aug 3, 2016
I find some of my servers have ipmi running on channel jhoblitt#2 only (plugged into different physical port maybe - who knows). so the impi_ipaddress etc facts (which come from channel jhoblitt#1) are not set. as channel jhoblitt#1 is not configured. instead of always taking channel jhoblitt#1 for these, could we take 'the first found LAN channel' instead? (asside: this is the behaviour when running 'ipmitool lan print' without picking a channel). have put in a suggested change for this. think it would work to only set each of the ipmi_<name> facts if not set so far. cheers,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial PR adds basic ipmievd server support and defaults to running the service. I can provide another commit that adds a class parameter to selectively turn it on.
This tracks issue #1.