added defined resources for network and user configuration

[ripclawffb]

also added documentation and examples for network and user defined resources

[jhoblitt]

The type declarations break compat with puppet 3.x. Could you convert these to validate_ functions? I think we need to support 3.x for a bit longer.

[ripclawffb]

I have made the requested changes. Thanks!

[ripclawffb]

I have made the changes. Thanks.

On Tue, Jun 21, 2016 at 6:20 PM -0700, "Joshua Hoblitt" notifications@github.com wrote:

The type declarations break compat with puppet 3.x. Could you convert these to validate_ functions? I think we need to support 3.x for a bit longer.

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#20 (comment)

[elisiano]

I didn't test it but this PR looks amazing! +1

[jhoblitt]

The travis failure was due to ruby 1.8.7, which can be ignored (this module needs a plumbing update).

This looks pretty reasonable to me. Would you be willing to add a few rspec unit tests?

[ripclawffb]

Sure, I’ll read up on it and see if I can write some tests. I’ve never done it before.

From: Joshua Hoblitt [mailto:notifications@github.com]
Sent: Thursday, June 23, 2016 6:56 PM
To: jhoblitt/puppet-ipmi puppet-ipmi@noreply.github.com
Cc: ripclawffb ripclaw_ffb@hotmail.com; Author author@noreply.github.com
Subject: Re: [jhoblitt/puppet-ipmi] added defined resources for network and user configuration (#20)

The travis failure was due to ruby 1.8.7, which can be ignored (this module needs a plumbing update).

This looks pretty reasonable to me. Would you be willing to add a few rspec unit tests?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #20 (comment) , or mute the thread https://github.com/notifications/unsubscribe/ATGp-t8TYIGw8XZXMSDf28CuUn-qpmR5ks5qOzkpgaJpZM4I7UfR . https://github.com/notifications/beacon/ATGp-id1bHqXBDHcA5vWVuIzWAdKJgcBks5qOzkpgaJpZM4I7UfR.gif

[ripclawffb]

I created the rspec tests for the new features and also incorporated some tests/changes from Pat. I had to remove the interface type setting since it wasn't working as expected. I think we can revisit after these initial features are merged. Appreciate the help.

[jhoblitt]

This looks good, doubly so for a first effort at rspec. I had figured managing ipmi would need to be done as a native type. Thanks for contributing!