Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large refactor for IPMI facts: #25

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Large refactor for IPMI facts: #25

merged 1 commit into from
Jun 30, 2016

Conversation

petems
Copy link
Contributor

@petems petems commented Jun 30, 2016

  • Use which method for checking if ipmitools present
  • Run command with exec helper
  • Simplify loop for channels (IPMI standard channels are 1-11)
  • Adds specs to check for correctness

Closes #24

@petems
Large refactor for IPMI facts:
d7bafed 
* Use which method for checking if ipmitools present
* Run command with exec helper
* Simplify loop for channels (IPMI standard channels are 1-11)
* Adds specs to check for correctness
@jhoblitt jhoblitt merged commit 4ad39a1 into jhoblitt:master Jun 30, 2016
@jhoblitt
Copy link
Owner

Thanks! I will cut a new release once #23 is merged.

@petems petems deleted the refactor_fact branch June 30, 2016 21:25
@petems petems mentioned this pull request Jun 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @jhoblitt