Set the ipmi service to stopped by default if no ipmi devices #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
force-pushed
the
status-follows-mac
branch
from
51ad49d
to
b5ee041
Compare
|
I feel like I'm close with the tests but just can't seem to get it right..... any help? |
jcpunk
force-pushed
the
status-follows-mac
branch
2 times, most recently
from
749b676
to
f0abb50
Compare
|
I understand the motivation behind this. #44 just removed |
|
This is a feature I'd like to have, I'll put a rework on my backlog. |
jcpunk
force-pushed
the
status-follows-mac
branch
2 times, most recently
from
eca6478
to
3317d04
Compare
|
In theory this is a cleaner approach than my previous attempt. In practice.... |
|
Kicking gha. |
jcpunk
force-pushed
the
status-follows-mac
branch
2 times, most recently
from
b552d97
to
79e68c5
Compare
jcpunk
force-pushed
the
status-follows-mac
branch
from
79e68c5
to
d0534ac
Compare
|
I finally found time to dig into the failing tests. In theory this should test cleanly now. |
jhoblitt
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the default state to
stoppedif no IPMI devices are detected.