Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable users #59

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jan 23, 2023

Rather than just setting the password to a random value, this extends the user management code to let a user be fully disabled.

@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 25, 2023

I do not understand the test failures...

@jhoblitt
Copy link
Owner

@jcpunk I am able to reproduce the errors.

manifests/network.pp Outdated Show resolved Hide resolved
manifests/snmp.pp Outdated Show resolved Hide resolved
@jcpunk jcpunk force-pushed the disable_user branch 4 times, most recently from 49453ce to 1a50757 Compare January 27, 2023 15:02
@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 27, 2023

I think I've got the tests passing. You can check the dep loop by pulling down this branch and dropping the require ipmi::install for require ipmi and running the test suite.

I'm showing:

dependency cycles found: (Exec[ipmi_user_add_newuser] => Ipmi::User[newuser] => Class[Ipmi] => Ipmi::User[newuser] => Exec[ipmi_user_add_newuser])

@jcpunk jcpunk requested a review from jhoblitt January 30, 2023 21:24
manifests/install.pp Outdated Show resolved Hide resolved
manifests/user.pp Show resolved Hide resolved
manifests/user.pp Show resolved Hide resolved
manifests/user.pp Show resolved Hide resolved
@jcpunk jcpunk force-pushed the disable_user branch 2 times, most recently from 881f3d4 to 489e301 Compare January 31, 2023 17:41
@jcpunk jcpunk requested a review from jhoblitt February 3, 2023 15:44
@jcpunk
Copy link
Contributor Author

jcpunk commented Feb 28, 2023

Just checking back in.

@jhoblitt
Copy link
Owner

jhoblitt commented Mar 3, 2023

Sorry for the slow response. I wanted to try to test this a box with a bmc before merging it. It looks like the gha failure on centos 8 is bogus. Could you touch the branch to retrigger it? It isn't giving me the re-run button.

@jcpunk jcpunk force-pushed the disable_user branch 3 times, most recently from 15ead23 to 2fbb57e Compare March 3, 2023 16:55
@jcpunk
Copy link
Contributor Author

jcpunk commented Mar 3, 2023

Any guesses why it doesn't like REFERENCE.md? I'm showing it is the current copy.

@jhoblitt
Copy link
Owner

jhoblitt commented Mar 3, 2023

@jcpunk running bundle exec rake reference on this branch does result in changes for me.

@jcpunk
Copy link
Contributor Author

jcpunk commented Mar 3, 2023

I've been running puppet strings generate --format markdown --out REFERENCE.md is that not the way?

I've run the other command and it is indeed different?

Copy link
Owner

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoblitt jhoblitt merged commit 1878c38 into jhoblitt:master Mar 6, 2023
@jcpunk jcpunk deleted the disable_user branch March 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants