Add lan channel fact and user channel support

[nathanlcarlson]

Based on #32 .

Intentionally named ::user parameter channel instead of lan_channel to be more general.

[jhoblitt]

@nathanlcarlson How would you feel about adding the channel as a structured fact. Something like ipmi.channel?

[nathanlcarlson]

@jhoblitt Sure. Just this fact or should I create a structure for all impi* facts? The current flat facts could remain and I could add docs about them being deprecated?

[jhoblitt]

@jhoblitt Sure. Just this fact or should I create a structure for all impi* facts? The current flat facts could remain and I could add docs about them being deprecated?

I was only hoping to stop the growth of top level facts but if your willing to do the full conversion, that would be fantastic!

[nathanlcarlson]

Kk, I made some standalone gathering and structuring of the facts. I'm not sure how REFERENCE.md gets updated or if there are other PDK items to take care of.

[nathanlcarlson]

Ahh, I found the reference update command in the test results.

[nathanlcarlson]

It looks like these remaining failures are related to CentOS package mirrors? Maybe partly related to the retirement of CentOS 7?

[nathanlcarlson]

Those may be difficult to resolve. Any chance we can just ignore them?

[jhoblitt]

Those may be difficult to resolve. Any chance we can just ignore them?

I think we should remove centos completely from metadata.json in another PR labeled as a breaking-change. Do you want to take that on too? 🙏

[nathanlcarlson]

I did my best to track down this issue and opened this voxpupuli/beaker-docker#144 and am trying the advice there.

[jhoblitt]

It's the plumbing in those module that needs to be updated. I'll run msync on it shortly.

[jhoblitt]

FYI:

• drop support for EL7 -- EOL #79
• drop support for ubuntu 18.04 -- EOL #80
• drop support for Debian 10 -- EOL #81
• Update from voxpupuli modulesync_config #82

[jhoblitt]

@nathanlcarlson CI is passing on master now. Could you try a rebase?

[jhoblitt]

LGTM. Thank you for doing the fact conversion!

[jhoblitt]

Released as https://github.com/jhoblitt/puppet-ipmi/tree/v6.0.0