Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaping slow kids with test #22

Merged
merged 8 commits into from Jun 7, 2016
Merged

Conversation

kensanata
Copy link
Contributor

@kensanata kensanata commented Jun 5, 2016

This adds a test for zombies left behind when using hypnotoad and a slow drip of requests, and it incorporates the fix by @knox1000. This takes care of both #20 and #21.

I didn't look at the suggestion in the comments of #20.

This also adds a test that the ended up not helping me find the bug, but I decided to leave it in. This also changes a file pattern in .gitignore for Emacs users.

@kensanata
Copy link
Contributor Author

kensanata commented Jun 5, 2016

Sadly, I have no idea what to do about the leaky pipes test. With TEST_PIPES, this test fails for 0.32 on my OSX laptop as well as on the Debian Wheezy server. (But then again, it also fails for older revisions on my systems?)

@jhthorsen jhthorsen added the bug label Jun 7, 2016
@jhthorsen jhthorsen self-assigned this Jun 7, 2016
@jhthorsen
Copy link
Owner

LGTM 👍

Thanks for the additional tests. I'm going to add "plan skip_all ..." to the hypnotoad test, since I don't think it should be required to run when installing.

@jhthorsen jhthorsen merged commit c8e7cb1 into jhthorsen:master Jun 7, 2016
jhthorsen pushed a commit that referenced this pull request Jun 7, 2016
 - Fix zombies left behind #20 #21 #22
@jhthorsen jhthorsen mentioned this pull request Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants