New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum perl version (5.10) #54

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@openstrike
Contributor

openstrike commented Dec 19, 2017

This module is my CPAN PR Challenge assignment for December.

Starting gently, here is a minor addition to specify the minimum perl version. The use of defined-or (//) in lib/Mojolicious/Plugin/OpenAPI.pm sets this at 5.10.

@jhthorsen jhthorsen self-requested a review Dec 19, 2017

@jhthorsen

This comment has been minimized.

Show comment
Hide comment
@jhthorsen

jhthorsen Dec 19, 2017

Owner

Isn't this already handled, since it depends on Mojolicious?

Owner

jhthorsen commented Dec 19, 2017

Isn't this already handled, since it depends on Mojolicious?

@jberger

This comment has been minimized.

Show comment
Hide comment
@jberger

jberger Dec 19, 2017

Collaborator

@jhthorsen in concept yes, but for metadata purposes it is probably useful to set it for dependent projects too. I don't always myself either, but I probably should.

Collaborator

jberger commented Dec 19, 2017

@jhthorsen in concept yes, but for metadata purposes it is probably useful to set it for dependent projects too. I don't always myself either, but I probably should.

@jhthorsen

This comment has been minimized.

Show comment
Hide comment
@jhthorsen

jhthorsen Dec 19, 2017

Owner

Cool! 👍

Owner

jhthorsen commented Dec 19, 2017

Cool! 👍

@jhthorsen jhthorsen merged commit a573057 into jhthorsen:master Dec 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jhthorsen

This comment has been minimized.

Show comment
Hide comment
@jhthorsen
Owner

jhthorsen commented Dec 19, 2017

@openstrike

This comment has been minimized.

Show comment
Hide comment
@openstrike

openstrike Dec 19, 2017

Contributor

Sure - the more the merrier.

Contributor

openstrike commented Dec 19, 2017

Sure - the more the merrier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment