New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check of yaml module when testing #67

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@soren

soren commented Feb 28, 2018

The JSON::Validator seems to require at least version 0.67 of YAML::XS
to work. If an older version is installed the the test fails. I've
changed the pre-condition to check for a specific version of YAML::XS,
and if it's not installed the test is skipped, just as if the modules
wasn't installed at all.

This should most/all of the CPAN Testers failures.

This is part of the CPAN Pull Request Challenge, where I got
Mojolicious::Plugin::OpenAPI as my February assignment.

Add version check of yaml module when testing
The JSON::Validator seems to require at least version 0.67 of YAML::XS
to work. If an older version is installed the the test fails. I've
changed the pre-condition to check for a specific version of YAML::XS,
and if it's not installed the test is skipped, just as if the modules
wasn't installed at all.

This should most/all of the CPAN Testers failures.

This is part of the CPAN Pull Request Challenge, where I got
Mojolicious::Plugin::OpenAPI as my February assignment.

@jhthorsen jhthorsen self-requested a review Mar 8, 2018

@jhthorsen jhthorsen added the bug label Mar 8, 2018

@jhthorsen

This comment has been minimized.

Owner

jhthorsen commented Mar 8, 2018

Awesome! 👍

@jhthorsen jhthorsen merged commit 66764db into jhthorsen:master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jhthorsen added a commit that referenced this pull request Mar 8, 2018

Released version 1.26
 - Fix skipping yaml.t, unless correct version of YAML::XS is available #67
   Contributor: Søren Lund
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment