New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello. Feel free to pick (and modify if need be) any or both of these: #7

Merged
merged 2 commits into from Mar 15, 2016

Conversation

Projects
None yet
3 participants
@bieron
Contributor

bieron commented Mar 3, 2016

cpanpr

@jhthorsen

This comment has been minimized.

Show comment
Hide comment
@jhthorsen

jhthorsen Mar 3, 2016

Owner

Thanks! This looks like an obvious bug.

Could you also provide a test case for this?

Owner

jhthorsen commented Mar 3, 2016

Thanks! This looks like an obvious bug.

Could you also provide a test case for this?

@bieron

This comment has been minimized.

Show comment
Hide comment
@bieron

bieron Mar 15, 2016

Contributor

Afraid not. I can't come up with a sensible real world test case, all I can think of is to stupidly mock content type and see if it passes or not, but that's more like testing the test itself, not the code.

Contributor

bieron commented Mar 15, 2016

Afraid not. I can't come up with a sensible real world test case, all I can think of is to stupidly mock content type and see if it passes or not, but that's more like testing the test itself, not the code.

singingfish added a commit that referenced this pull request Mar 15, 2016

Merge pull request #7 from bieron/master
Hello. Feel free to pick (and modify if need be) any or both of these:

@singingfish singingfish merged commit af8d83e into jhthorsen:master Mar 15, 2016

@singingfish

This comment has been minimized.

Show comment
Hide comment
@singingfish

singingfish Mar 15, 2016

Collaborator

I hit a going-into-production bug with this and perl 5.10.1 a few minutes ago, so I merged and did a release.

Collaborator

singingfish commented Mar 15, 2016

I hit a going-into-production bug with this and perl 5.10.1 a few minutes ago, so I merged and did a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment