Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes the timestamp in dependency version.
I’ve also pinned
github.com/golang/glog
module version (that’s whatgo mod tidy
does anyway).The
go.mod
in this project does not work withgo1.13
(checked out at golang/go@2d6ee6e89a). The project depends ongoogle.golang.org/genproto@v0.0.0-20170818
10
0345-ee236bd376b0
, but the timestamp is invalid. It should be20170818
01
0345
instead. See googleapis/go-genproto@ee236bdSteps to reproduce:
Note that the those steps won’t cause an error with go1.12. Running
go1.13 mod tidy
aftergo1.12 mod tidy
succeeds, so we have to clean the mod cache. Moreover, the [broken] module version is cached in the defaultGOPROXY=https://proxy.golang.org
so we have to disable that too.