Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic/msgregistry: Add typed errors for lookups #386

Merged
merged 2 commits into from Mar 2, 2021

Conversation

johanbrandhorst
Copy link
Contributor

@johanbrandhorst johanbrandhorst commented Mar 2, 2021

Adds typed errors used when looking up a message and finding an enum or vice versa.

dynamic/msgregistry/message_registry.go Outdated Show resolved Hide resolved
dynamic/msgregistry/message_registry.go Outdated Show resolved Hide resolved
dynamic/msgregistry/message_registry.go Outdated Show resolved Hide resolved
Adds typed error used when looking up a
message and finding an enum or vice versa.
jhump
jhump approved these changes Mar 2, 2021
Copy link
Owner

@jhump jhump left a comment

LGTM!

The errors.As syntax is not supported on pre-1.13
versions of Go.
@jhump jhump merged commit 8255811 into jhump:master Mar 2, 2021
1 check passed
@johanbrandhorst johanbrandhorst deleted the add-typed-registry-errors branch Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants