Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoparse: take 3... still getting scoping rules right #399

Merged
merged 1 commit into from May 29, 2021

Conversation

jhump
Copy link
Owner

@jhump jhump commented May 29, 2021

I thought of a scenario in which the previous attempt (#397) still wouldn't resolve things correctly. So I augmented the test case to confirm the problem. And now, with some more fixes/changes, the new test case passes, too.

Boy I really hope this is it...

@jhump jhump merged commit e5cc6ba into master May 29, 2021
5 checks passed
@jhump jhump deleted the jh/yet-another-fix-to-scope branch May 29, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant