Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoparse: doh! we weren't resolving options for oneofs during linking #408

Merged
merged 1 commit into from Jul 12, 2021

Conversation

jhump
Copy link
Owner

@jhump jhump commented Jul 12, 2021

The link step that resolves identifiers into fully-qualified names was failing to ever examine/process custom option names for oneofs.

So this adds a linker test case that includes every kind of option. This reproduced the reported issue and now passes with the main code changes.

Fixes #406.

@jhump jhump mentioned this pull request Jul 12, 2021
@jhump jhump merged commit d3608fa into master Jul 12, 2021
5 checks passed
@jhump jhump deleted the jh/oo-options branch Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant