New reticulate#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the reticulate initialization to use the new py_require method and removes outdated forest installation functions. The key changes include:
- Adoption of reticulate::py_require in the .onLoad function for more robust Python environment management.
- Removal of deprecated forest-related functions and associated documentation/examples.
- Updates to example usage in Rd files by removing the forest dependency checks.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| walking.Rproj | Added a unique ProjectId to the project configuration. |
| tests/testthat.R | Commented out code testing conda environment setup. |
| man/verisense_count_steps.Rd | Removed forest dependency check in examples. |
| man/forest_setup.Rd | Removed outdated documentation for forest installation. |
| man/find_walking.Rd | Removed forest dependency check in examples. |
| man/estimate_steps.Rd | Removed forest dependency check in examples. |
| R/zzz.R | Introduced reticulate::py_require for initializing the forest module. |
| R/verisense_count_steps.R | Updated commented example removing forest dependency check. |
| R/sdt.R | Updated fixed thresholds for wrist and waist measurements. |
| R/install_forest.R | Removed deprecated forest installation functions. |
| R/find_walking.R | Updated commented example removing forest dependency check. |
| R/api.R | Updated commented example removing forest dependency check. |
| NEWS.md | Added release notes for version 0.4.0 and related changes. |
| NAMESPACE | Removed exports for deprecated forest functions. |
| DESCRIPTION | Bumped package version and updated reticulate dependency. |
| .github/workflows/R-CMD-check.yaml | Updated Python version to 3.11 and commented out forest setup. |
Comments suppressed due to low confidence (1)
R/sdt.R:38
- Please verify that the updated threshold values for 'wrist' and 'waist' are correct and that the associated comment accurately reflects the changes; if these values are intentional, documenting their rationale would aid future maintainability.
threshold = ifelse(location == "wrist", 0.0359, 0.0267)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now uses the new
py_requirefor the new reticulate: https://posit.co/blog/reticulate-1-41/