Skip to content

New reticulate#2

Merged
muschellij2 merged 2 commits into
mainfrom
new_reticulate
May 23, 2025
Merged

New reticulate#2
muschellij2 merged 2 commits into
mainfrom
new_reticulate

Conversation

@muschellij2
Copy link
Copy Markdown
Collaborator

Now uses the new py_require for the new reticulate: https://posit.co/blog/reticulate-1-41/

@muschellij2 muschellij2 merged commit 86c13bb into main May 23, 2025
1 check passed
@muschellij2 muschellij2 requested a review from Copilot May 23, 2025 16:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the reticulate initialization to use the new py_require method and removes outdated forest installation functions. The key changes include:

  • Adoption of reticulate::py_require in the .onLoad function for more robust Python environment management.
  • Removal of deprecated forest-related functions and associated documentation/examples.
  • Updates to example usage in Rd files by removing the forest dependency checks.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
walking.Rproj Added a unique ProjectId to the project configuration.
tests/testthat.R Commented out code testing conda environment setup.
man/verisense_count_steps.Rd Removed forest dependency check in examples.
man/forest_setup.Rd Removed outdated documentation for forest installation.
man/find_walking.Rd Removed forest dependency check in examples.
man/estimate_steps.Rd Removed forest dependency check in examples.
R/zzz.R Introduced reticulate::py_require for initializing the forest module.
R/verisense_count_steps.R Updated commented example removing forest dependency check.
R/sdt.R Updated fixed thresholds for wrist and waist measurements.
R/install_forest.R Removed deprecated forest installation functions.
R/find_walking.R Updated commented example removing forest dependency check.
R/api.R Updated commented example removing forest dependency check.
NEWS.md Added release notes for version 0.4.0 and related changes.
NAMESPACE Removed exports for deprecated forest functions.
DESCRIPTION Bumped package version and updated reticulate dependency.
.github/workflows/R-CMD-check.yaml Updated Python version to 3.11 and commented out forest setup.
Comments suppressed due to low confidence (1)

R/sdt.R:38

  • Please verify that the updated threshold values for 'wrist' and 'waist' are correct and that the associated comment accurately reflects the changes; if these values are intentional, documenting their rationale would aid future maintainability.
threshold = ifelse(location == "wrist", 0.0359, 0.0267)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants