Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump tough-cookie from 2.3.2 to 2.3.4 #137

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 14, 2018

Bumps tough-cookie from 2.3.2 to 2.3.4. This update includes security fixes.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

High severity vulnerability that affects tough-cookie
A ReDoS (regular expression denial of service) flaw was found in the tough-cookie module before 2.3.3 for Node.js. An attacker that is able to make an HTTP request using a specially crafted cookie may cause the application to consume an excessive amount of CPU.

Affected versions: <2.3.3

Sourced from The Sonatype OSS Index.

CWE-185: Incorrect Regular Expression
The software specifies a regular expression in a way that causes data to be improperly matched or compared.

Affected versions: >=0.9.1 <2.3.3

Commits
  • e4dfb0a 2.3.4
  • 7d66ffd Update public suffix list
  • 7564c06 Merge pull request #100 from salesforce/no-re-parser
  • 751da6d Document removal of 256 space limit
  • 8452ccd Convert date-time parser from regexp, expand tests
  • 8614dbf More String#repeat polyfill
  • 2a4775c Avoid unbounded Regexp parts in date parsing
  • c9bd79d Parse cookie-pair part without regexp
  • 12d4266 2.3.3
  • 98e0916 Merge pull request #97 from salesforce/spaces-ReDoS
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.


This change is Reviewable

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 2.3.2 to 2.3.4. **This update includes security fixes.**
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Commits](salesforce/tough-cookie@v2.3.2...v2.3.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Nov 14, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d984023 on dependabot/npm_and_yarn/tough-cookie-2.3.4 into cd8986e on master.

@jhwohlgemuth jhwohlgemuth merged commit 02a44af into master Apr 4, 2020
@jhwohlgemuth jhwohlgemuth deleted the dependabot/npm_and_yarn/tough-cookie-2.3.4 branch April 4, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants