Parsing encoding problem with .html() on <style> tag #1186

mino181295 · 2019-03-15T00:03:36Z

I have a problem parsing and then setting the <style> tag.
When I do .html() and then set back the string with .html(s) I get the HTML entity < that does not work correctly in CSS.

When I do:

        String html = ""
                + "<html>"
                + " <head>"
                + "     <style>.outer > .inner {background-color:white;}</style>"
                + " </head>"
                + " <body>"
                + "     Example"
                + " </body>"
                + "</html>";
        Document document = Jsoup.parse(html);
        Element style = document.selectFirst("style");
        
        String s = style.html();
        //..
        style.html(s);
        
        System.out.println(document.toString());

I get:

<html>
 <head>
  <style>.outer &gt; .inner {background-color:white;}</style>
 </head>
 <body>
   Example
 </body>
</html>

But I'm expecting that the style tag preserve the > selector or it won't work correctly.
I'm expecting that the result HTML code is:

<html>
 <head>
  <style>.outer > .inner {background-color:white;}</style>
 </head>
 <body>
   Example
 </body>
</html>

I would be happy to contribute to an eventual patch if you give me some hints.

The text was updated successfully, but these errors were encountered:

mino181295 · 2019-03-18T13:19:41Z

@jhy

lnostdal · 2019-03-21T14:33:57Z

Work on a clone in order to avoid mutating the document instance. Essentially the same as your code, but in Clojure

symbolicweb.core> (let [document (Jsoup/parse (str ""
                                                   "<html>"
                                                   " <head>"
                                                   "     <style>.outer > .inner {background-color:white;}</style>"
                                                   " </head>"
                                                   " <body>"
                                                   "     Example"
                                                   " </body>"
                                                   "</html>"))
                        style (.selectFirst document "style")]
                    (println (.toString (.html style (.html style))))
                    (println "\n###\n")
                    (println (.toString document)))
<style>.outer &gt; .inner {background-color:white;}</style>

###

<html>
 <head> 
  <style>.outer &gt; .inner {background-color:white;}</style> 
 </head> 
 <body>
   Example 
 </body>
</html>
nil
symbolicweb.core>

...when we use .clone, it is fixed:

symbolicweb.core> (let [document (Jsoup/parse (str ""
                                                   "<html>"
                                                   " <head>"
                                                   "     <style>.outer > .inner {background-color:white;}</style>"
                                                   " </head>"
                                                   " <body>"
                                                   "     Example"
                                                   " </body>"
                                                   "</html>"))
                        style (.clone (.selectFirst document "style"))]
                    (println (.toString (.html style (.html style))))
                    (println "\n###\n")
                    (println (.toString document)))
<style>.outer &gt; .inner {background-color:white;}</style>

###

<html>
 <head> 
  <style>.outer > .inner {background-color:white;}</style> 
 </head> 
 <body>
   Example 
 </body>
</html>
nil
symbolicweb.core>

eolivelli · 2019-03-22T08:31:16Z

I have found the problem.
In @mino181295 case we have to mutate the STYLE element (the example was not complete).

Mutating STYLE element must not be done with Element.html() but with a DataNode

I am sending a Pull Request with an example in form of test case
#1186

mino181295 · 2019-03-22T19:06:08Z

Thank you @eolivelli that solved the problem.

jhy · 2020-12-29T03:31:59Z

This was fixed with #1419

mino181295 changed the title ~~Problems .html() on <style> tag~~ Parsing encoding problem with .html() on <style> tag Mar 15, 2019

eolivelli mentioned this issue Mar 22, 2019

Add Testcase with an Example of CSS Manipulation #1191

Closed

jhy added the duplicate This is a duplicate issue or root-cause of another issue label Dec 29, 2020

jhy closed this as completed Dec 29, 2020

jhy added a commit that referenced this issue Dec 29, 2020

Test for #1186

1a0ba6a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parsing encoding problem with .html() on <style> tag #1186

Parsing encoding problem with .html() on <style> tag #1186

mino181295 commented Mar 15, 2019

mino181295 commented Mar 18, 2019

lnostdal commented Mar 21, 2019 •

edited

eolivelli commented Mar 22, 2019 •

edited

mino181295 commented Mar 22, 2019

jhy commented Dec 29, 2020

Parsing encoding problem with .html() on <style> tag #1186

Parsing encoding problem with .html() on <style> tag #1186

Comments

mino181295 commented Mar 15, 2019

mino181295 commented Mar 18, 2019

lnostdal commented Mar 21, 2019 • edited

eolivelli commented Mar 22, 2019 • edited

mino181295 commented Mar 22, 2019

jhy commented Dec 29, 2020

lnostdal commented Mar 21, 2019 •

edited

eolivelli commented Mar 22, 2019 •

edited