From b5aa0f459907d1d1fa514883e389e1f1fd8b5841 Mon Sep 17 00:00:00 2001 From: Jianghao Lu Date: Tue, 6 Sep 2016 12:23:34 -0700 Subject: [PATCH] Remove ServiceResponse<> wrappers in most methods --- .../java/com/microsoft/azure/AzureServiceCall.java | 2 +- .../main/java/com/microsoft/rest/ServiceCall.java | 12 ++++++------ .../java/com/microsoft/rest/ServiceCallback.java | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/azure-client-runtime/src/main/java/com/microsoft/azure/AzureServiceCall.java b/azure-client-runtime/src/main/java/com/microsoft/azure/AzureServiceCall.java index 0bc20202495d4..e9c8728b67f97 100644 --- a/azure-client-runtime/src/main/java/com/microsoft/azure/AzureServiceCall.java +++ b/azure-client-runtime/src/main/java/com/microsoft/azure/AzureServiceCall.java @@ -117,7 +117,7 @@ public void onNext(ServiceResponse> serviceResponse) { } } if (behavior == ListOperationCallback.PagingBehavior.STOP || serviceResponse.getBody().getNextPageLink() == null) { - serviceCall.set(new ServiceResponse<>(lastResponse.getBody().getItems(), lastResponse.getResponse())); + serviceCall.set(lastResponse.getBody().getItems()); } else { serviceCall.setSubscription(next.call(serviceResponse.getBody().getNextPageLink()).single().subscribe(this)); } diff --git a/client-runtime/src/main/java/com/microsoft/rest/ServiceCall.java b/client-runtime/src/main/java/com/microsoft/rest/ServiceCall.java index d256c118a0305..949ef7b8879f2 100644 --- a/client-runtime/src/main/java/com/microsoft/rest/ServiceCall.java +++ b/client-runtime/src/main/java/com/microsoft/rest/ServiceCall.java @@ -20,7 +20,7 @@ * * @param the type of the returning object */ -public class ServiceCall extends AbstractFuture> { +public class ServiceCall extends AbstractFuture { /** * The Retrofit method invocation. */ @@ -43,7 +43,7 @@ public static ServiceCall create(final Observable> obs .subscribe(new Action1>() { @Override public void call(ServiceResponse t) { - serviceCall.set(t); + serviceCall.set(t.getBody()); } }, new Action1() { @Override @@ -70,9 +70,9 @@ public static ServiceCall create(final Observable> obs @Override public void call(ServiceResponse t) { if (callback != null) { - callback.success(t); + callback.success(t.getBody()); } - serviceCall.set(t); + serviceCall.set(t.getBody()); } }, new Action1() { @Override @@ -103,9 +103,9 @@ public static ServiceCall createWithHeaders(final Observable t) { if (callback != null) { - callback.success(t); + callback.success(t.getBody()); } - serviceCall.set(t); + serviceCall.set(t.getBody()); } }, new Action1() { @Override diff --git a/client-runtime/src/main/java/com/microsoft/rest/ServiceCallback.java b/client-runtime/src/main/java/com/microsoft/rest/ServiceCallback.java index dd3791bbb2d19..c3961b880a80f 100644 --- a/client-runtime/src/main/java/com/microsoft/rest/ServiceCallback.java +++ b/client-runtime/src/main/java/com/microsoft/rest/ServiceCallback.java @@ -23,7 +23,7 @@ public abstract class ServiceCallback { /** * Override this method to handle successful REST call results. * - * @param result the ServiceResponse holding the response. + * @param result the result object. */ - public abstract void success(ServiceResponse result); + public abstract void success(T result); }