Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Attempted fix for issue #190 #191

Merged
merged 1 commit into from

2 participants

@josh-

These two methods on NSURL,

- (NSString *)absoluteString

and

- (NSString *)path

return different values. According to the docs, path is "suitable for input into methods of NSFileManager or NSPathUtilities", whereas absoluteString is not.

I don't have a copy of Snow Leopard handy, so someone will have to confirm this path does indeed fix #190 before merging.

@jigish
Owner

on vacation currently. I'll take a look when I get back around jan 6th. I also don't have a copy of Snow Leopard, though, so if someone does it'd be great if they could try this fix out.

@josh-

@jigish Sounds good mate, have a great vacation. I'll also see if I can get SL going in a VM or something in the next couple of days to try this out.

@jigish jigish merged commit 50e31f0 into jigish:master
@jigish
Owner

sorry this took so long =/. merged now and will push a build later today.

@jigish jigish referenced this pull request from a commit
Jigish Patel Version 1.0.17
- Merge Pull Request #191 - (Fix Issue #190)
- Merge Pull Request #166 - (Fix Issue #130)
- Merge Pull Request #204
- Merge Pull Request #185
5620a30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 27, 2012
  1. @josh-

    Attempted fix for issue #190

    josh- authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Slate/NSFileManager+ApplicationSupport.m
View
2  Slate/NSFileManager+ApplicationSupport.m
@@ -44,7 +44,7 @@ - (NSURL *)findOrCreateDirectory:(NSSearchPathDirectory)searchPathDirectory inDo
if (major >= 10 && minor >= 7) {
success = [self createDirectoryAtURL:url withIntermediateDirectories:YES attributes:nil error:&error];
} else {
- success = [self createDirectoryAtPath:[url absoluteString] withIntermediateDirectories:YES attributes:nil error:&error];
+ success = [self createDirectoryAtPath:[url path] withIntermediateDirectories:YES attributes:nil error:&error];
}
if (!success) {
if (errorOut) *errorOut = error;
Something went wrong with that request. Please try again.