Skip to content

Upgraded Travis-CI Test Script #682

Merged
merged 79 commits into from Nov 21, 2012

7 participants

@chriscct7
Jigoshop member

This pull request improves Pull Request #653.

It took a "few" commits to merge @schorsch's pull into what I already have, but in the end, we have a greatly improved script. We now can test multiple PHP versions, WP versions, and MU (y/n).
I wrote a wiki page here that explains how to integrate Travis after the pull is done.

Merge away

If you want to see the test, the latest build is available here

schorsch and others added some commits Aug 17, 2012
@schorsch schorsch add wordpress-test submodule, test readme 6d1c382
@schorsch schorsch fix readme 98f9f71
@schorsch schorsch explicit add test class suffix, minor readme fix c261177
@schorsch schorsch first try for travis-ci a5c9fb1
@schorsch schorsch change travis.yml a70f3e8
@schorsch schorsch more travis updates 6c1954c
@schorsch schorsch try using full path to wordpress 1d2dd61
@schorsch schorsch another file path travis try c649ad0
@schorsch schorsch db user is root in travis c550d15
@schorsch schorsch create travis db 24b4882
@schorsch schorsch add travis test-setup to tests/ add travis icon 9efd6ad
@chriscct7clone chriscct7clone Merge pull request #1 from jigoshop/dev
Dev
a6b7f28
@chriscct7clone chriscct7clone Update tests/README.md f6a3d55
@chriscct7clone chriscct7clone Update .travis.yml 337b569
@chriscct7clone chriscct7clone Update .travis.yml 8ae0916
@chriscct7clone chriscct7clone Update tests/unittests-config.travis.php 40bb550
@chriscct7clone chriscct7clone Update README.md 45d6784
@chriscct7clone chriscct7clone Update README.md 420ce52
@chriscct7clone chriscct7clone Update .travis.yml d9e0141
@chriscct7clone chriscct7clone Update .travis.yml 9ca6093
@chriscct7clone chriscct7clone Update .travis.yml 13c9fd0
@chriscct7clone chriscct7clone Update .travis.yml dde760b
@chriscct7clone chriscct7clone Update .travis.yml 694be6f
@chriscct7clone chriscct7clone Add php 65d9d59
@chriscct7clone chriscct7clone Update .travis.yml 6465651
@chriscct7clone chriscct7clone Update .travis.yml 980b690
@chriscct7clone chriscct7clone Update tests/classes/jigoshopTest.php 2135389
@chriscct7clone chriscct7clone Update tests/classes/jigoshopTest.php fe4a6ce
@chriscct7clone chriscct7clone Update .travis.yml 8752fa0
@chriscct7clone chriscct7clone Update .travis.yml 3949ad8
@chriscct7clone chriscct7clone Update tests/classes/jigoshopTest.php cd7bc9e
@chriscct7clone chriscct7clone missed a brace d3e0ba0
@chriscct7clone chriscct7clone Update tests/classes/jigoshopTest.php c959021
@chriscct7 chriscct7 Merge pull request #1 from chriscct7clone/dev
Pull from Chriscct7clone
52a8bb9
@chriscct7 chriscct7 Removed the two failing test
will add them back in when I have time to rework them
61d5c5d
@chriscct7 chriscct7 Switch to my image c4a329a
@chriscct7 chriscct7 Fix Travis.yml 3c71a61
@chriscct7 chriscct7 Fix Traivs 2 47418ee
@chriscct7 chriscct7 Final one..ready to go 80e98e6
@chriscct7
Jigoshop member

Kind of an interesting process to get to this point. I had to create a second account to do it. Steps:

  1. Fork @schorsch's repo into chriscct7clone
  2. Pull request Jigoshop into chriscct7clone
  3. Edit the code a little bit
  4. Fork Jigoshop using chriscct7
  5. Pull chriscct7clone into chriscct7
  6. Set up Travis-CI
  7. Couple more commits
  8. Write wiki page +submit pull request
@divergeinfinity

Ok, given it a quick skim, and the first obstacle after looking over your 'wiki' may well be ... @studioromeo is probably going to have to do some or all of this to get it in.

I expect Rob, that the owner of the repository is going to have do the initial instructions at least?

@chriscct7
Jigoshop member

@divergeinfinity yep.
Should I do ahead and do the addon commit to change those 3 lines?

@studioromeo Rob: Your presence is requested :P

@schorsch

@chriscct7 awesome, thanks Mr MergeAlot

@chriscct7
Jigoshop member

@schorsch Haha :-). Actually, wasn't that bad pulling your repo up to date. More of the challenge, was, once it was up to date in @chriscct7clone getting the script to be able to test different versions of WordPress, with or without WPMU. You'll notice we use two environment parameters, so we can test alot of different combos. And it works....Theres a link to the current Travis results above.

@divergeinfinity

Rob doesn't work weekends and we may have to leave this a bit longer.

Wondering as well Rob, RHR implications?

For now, just leave it Chris, we'll 'git er done'.

@chriscct7
Jigoshop member

I'll go ahead and answer your RHR implications question:
Travis-CI, the free one, does not work for private repos. You would need upcoming Travis-CI Pro for that.

-Chris

@chriscct7
Jigoshop member

@studioromeo Any progress on this?

@studioromeo

Progress on?

@chriscct7
Jigoshop member

On merging this. Jeff has some questions ^ for you.

@studioromeo

@divergeinfinity whats your question? You should be able to merge pull requests?

@chriscct7
Jigoshop member

@studioromeo But as repo owner, I think you have to setup the Travis-CI account and admin hook, as per the wiki (link in merge description) instructions.

@studioromeo

Ah right ok I'll have a play (first travis ive set up so bare with)

@chriscct7
Jigoshop member

Ok just updated for the pull. All Chriscct7 repo references swictched to jigoshop

@studioromeo

Cool beans! This won't work until we figure out what we're doing with RHR anyway

@chriscct7
Jigoshop member

cough RHR access would be nice cough :P

@seanible

Chris, if you want RHR access you would request it via me

@chriscct7
Jigoshop member

@seanible Okay. I would like RHR access :-)

@chriscct7
Jigoshop member

@studioromeo How does this pull affect RHR right now though? If we do this pull we would be doing it upstream of RHR, and you could always pull the this pull to RHR as well.

@divergeinfinity

Sorry folks, I appreciate the effort put into it and by most accounts it's something we want, but I won't accept this without a clearer indication of the consequences of hauling it into RHR. And I will have to do that.

So at the moment, I am "disinclined to acquiesce to your request". :-p

Prior to next weeks release of Jigoshop 1.4 as a result, this isn't going to happen and won't make the release as I am quite unprepared to make any decision on RHR prior to that.

@chriscct7
Jigoshop member

If merged into RHR, there would be no bad consequences. Travis-CI can't test from a private repo (w/o a Pro account).
Therefore, there is no consequences off putting it in both.

-Chris

@studioromeo

Leave it with us @chriscct7, we need time to figure out where we are & where we're going.

chriscct7 added some commits Oct 17, 2012
@chriscct7 chriscct7 Merge pull request #2 from jigoshop/dev
Dev
2399477
@chriscct7 chriscct7 Merge in Rob's 19136ee
@chriscct7 chriscct7 Test new Tests ;) 9b885df
@chriscct7 chriscct7 Fix Rob's require_once calls 886bca0
@chriscct7 chriscct7 try2 5ac3d6a
@chriscct7 chriscct7 Travis's directories seem to be messed up 2bb7e13
@chriscct7 chriscct7 Travis stuck? e1fb65c
@chriscct7 chriscct7 Revert "Travis stuck?"
This reverts commit e1fb65c527513820c25b963831859b0cf240e7c0.
ad47c55
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php dc9f7c7
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php eead812
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php 80bfae1
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php e96ab82
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php 169c37a
@chriscct7 chriscct7 Update tests/classes/customer_jigoshopTest.php b4a3fb3
@chriscct7 chriscct7 Update .gitmodules 687b962
@chriscct7 chriscct7 Revert "Update .gitmodules"
This reverts commit 687b962666e4523e6e04b1f1efdacd0fc4a0cfa1.
2bb030b
@chriscct7 chriscct7 test
test
51ab459
@chriscct7 chriscct7 Revert "test"
This reverts commit 51ab4599ece084f81f3853364e484e220d8a9f7b.
ea23355
@chriscct7 chriscct7 here goes 7c48568
@chriscct7 chriscct7 dont start session 8cc4927
@chriscct7 chriscct7 stop that session 3a0c828
@chriscct7 chriscct7 brace for it 7eb0e7e
@chriscct7 chriscct7 steady now e29d1d1
@chriscct7 chriscct7 another one cf1b138
@chriscct7 chriscct7 another session d837808
@chriscct7 chriscct7 Missed SR's class change eb447af
@chriscct7 chriscct7 fix both errors 9a575ee
@chriscct7 chriscct7 Add test file and check for it in sessions 177a566
@chriscct7 chriscct7 need another ")" 7f6b2c8
@chriscct7 chriscct7 Jeez
Thanks Matt
66c6344
@chriscct7 chriscct7 Clean for merge + add vendors Readme
also move configtest
9ebfd0c
@chriscct7 chriscct7 Update .gitignore
Adds exceptions for:
Some new win/mac
Notepad++
Sublime
Code::Blocks
NetBeans
bb670c2
@chriscct7 chriscct7 Update travis.yml
Adds more tests and finalizes
83388a7
@chriscct7
Jigoshop member

This script is now ready. Contains @studioromeo's tests.
This is ready for merge.
It has already helped us find 1 issue on WP 3.4.2 and lower versions, and 3 issues on the WP Beta 3.5.0 versions (one of which is a new 3.5.0 deprecation error). This is really great. I think @Geczy's enjoying this right now :+1:

No need to install anything. Everytime you push to dev, or get a pull request, tests will be run for you. To see the results:
On Push to Dev/Commit to Dev: click the build status button on the top of the README
On Pull Request: http://about.travis-ci.org/blog/2012-09-04-pull-requests-just-got-even-more-awesome/

I will log the issues Travis has detected in a couple minutes

-Chris

@Geczy
Jigoshop member
Geczy commented Oct 19, 2012

Woot woot!

chriscct7 added some commits Oct 19, 2012
@chriscct7 chriscct7 Final Commit For Unit Testing 0363a5d
@chriscct7 chriscct7 Final Commit
Seems 3.2.1 slipped through our allowed_fails build matrix. Fixes that.
612998e
@studioromeo

@chriscct7 any talk of unit tests / travis should be contained here

@chriscct7
Jigoshop member

@studioromeo This is ready for inclusion in 1.4.5. Can we get in in?

@chriscct7
Jigoshop member

Can we merge this into 1.4.5? Not sure why we can't merge it in, and @studioromeo setup the Travis hook in the Admin section of this repo.
We are sitting on valuable tests, which have found us several bugs already.
I'd like to merge this in asap so that I can start writing more tests.

Any objections?

@studioromeo

Says merge with caution? Being the cautious type should we still merge this?

@divergeinfinity

I believe Chris has to do something with it first after you have done whatever you need to do. Chris?

@chriscct7
Jigoshop member
@chriscct7
Jigoshop member

I'm on Skype if anyone needs me as well :)

@studioromeo

This is gonna need some more thought as I don't really want to have my user account tied to all this stuff. It's bad enough all tender tickets go through my account. Will probs make a new user for system work

@chriscct7
Jigoshop member

That hook has to be done by the repo owner, so you could transfer the ownership to a Jigoshop user, and then have him be admin. Thats done by hitting the transfer ownership button on the admin page for the repo. Takes Github approx 60 seconds to transfer the ownership and then we are ready for merge.

@studioromeo

That's only for user owned repos, this is an organisation which makes management slightly different due to its shared nature

@studioromeo studioromeo merged commit 25e222c into jigoshop:dev Nov 21, 2012
@studioromeo

Done mate but it doesn't seem to be working any ideas?

@studioromeo

Ignore my last, working now. I'd say we could remove a few of these tests though, we only really need to test the latest minor points not hotfixes so eg:

WP 3.3.2
WP 3.4.2
WP 3.5

As for us hotfixes won't make any difference to the outcome of our tests

@chriscct7 chriscct7 referenced this pull request Nov 21, 2012
Merged

Travis Test Updates #723

@chriscct7
Jigoshop member

See #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.