introduce reindex query#101
Merged
Merged
Conversation
barbulescu
commented
Jan 6, 2024
barbulescu
commented
Jan 6, 2024
Owner
|
Looks good. Are you planning to do more work or is this good to go? |
Contributor
Author
|
I think is ready now for review. |
| class ReindexSourceDSL : JsonDsl() { | ||
| class ReindexSourceDSL : JsonDsl(), QueryClauses { | ||
| var index: String by property() | ||
| var query: ESQuery |
Owner
There was a problem hiding this comment.
This should work. You could also just make query a nullable constructor parameter and deal with it in the same way as here:
class FilterAgg(filter: ESQuery): AggQuery("filter") {
init {
this[name]=filter.wrapWithName()
}
}Either is fine of course.
jillesvangurp
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce query DSL for reindex source.