Add support for join field mappings#112
Merged
jillesvangurp merged 1 commit intojillesvangurp:masterfrom Feb 2, 2024
Merged
Conversation
This was referenced Feb 1, 2024
Owner
|
Awesome. I think you would also need the related queries and aggrgegation support to use this. But that can be done later with another PR if you feel up to it. |
Contributor
Author
|
My current use case is just for create indices and insert data, so I dont need the queries right now. However, you are right it would be great if the library supported it. I'm happy to have a look at adding support for this though |
Owner
|
Thanks for this. I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for join field types in index mappings
See Elasticsearch documentation: https://www.elastic.co/guide/en/elasticsearch/reference/current/parent-join.html
The documentation has the following example of a simple join field:
With the added
JoinDefinitionandjoin()you can now replicate this:This produces:
{ "mappings": { "properties": { "my_join_field": { "type": "join", "relations": { "question": [ "answer" ] } } } } }The only difference here is
questionis always a list even if there is only 1 value, as far as I'm aware this shouldn't be a problemThe documentation also has a slightly more complex example with multiple levels of relation:
This can also be replicated like so:
Which produces:
{ "mappings": { "properties": { "my_join_field": { "type": "join", "relations": { "question": [ "answer", "comment" ], "answer": [ "vote" ] } } } } }