adds key_as_string for boolean aggregation result.#138
Merged
jillesvangurp merged 1 commit intojillesvangurp:masterfrom May 8, 2024
Merged
adds key_as_string for boolean aggregation result.#138jillesvangurp merged 1 commit intojillesvangurp:masterfrom
jillesvangurp merged 1 commit intojillesvangurp:masterfrom
Conversation
From "Boolean field type" docs: Aggregations like the terms aggregation use 1 and 0 for the key, and the strings "true" and "false" for the key_as_string. https://www.elastic.co/guide/en/elasticsearch/reference/current/boolean.html
jillesvangurp
approved these changes
May 8, 2024
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From "Boolean field type" docs:
Aggregations like the terms aggregation use 1 and 0 for the key, and the strings "true" and "false" for the key_as_string.
https://www.elastic.co/guide/en/elasticsearch/reference/current/boolean.html
Sorry for many PRs at once 🙏 we recently started to use the library actively and have found out few parts which can be improved.