Add support for Linux platform#152
Merged
jillesvangurp merged 9 commits intoNov 25, 2024
Merged
Conversation
Owner
|
Thanks for fixing this! |
Owner
|
Still not passing in CI unfortunately, any ideas on how to fix this? |
Owner
|
Also not really liking the nix/flake dependency. Can you get rid of that? |
Owner
|
can you merge master? I removed the bit that attempts to install libcurl headers. Not sure if that is still needed for Linux support but wasn't working in any case. |
Contributor
Author
oh, I've just pushed another change installing libcurl, because indeed it's needed. Also, I've removed the nixos-related stuff (added the files to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151
What I did was:
LDFLAGenvironment variable.KtorRestClient.linux.ktthat usesCurlI only tested it (and it works pretty well, with no issues so far) on LinuxX64, both locally (my dev environment uses NixOS) and on docker images.