Skip to content

Jim P
jim-p

  • Joined on Dec 30, 2009

Organizations

@bsdperimeter
May 4, 2016
jim-p commented on pull request pfsense/pfsense-packages#1253
@jim-p

Looks like a good fix but it should probably be fixed at the root of the problem: 1. Validate on save in the GUI and don't save an invalid URL 2. V…

May 4, 2016
jim-p commented on pull request pfsense/pfsense-packages#1253
@jim-p

See the style guide for recommendations here -- always use curly braces in these cases. The code in that file is a bit of a mess but it's still bet…

May 4, 2016
jim-p commented on pull request pfsense/pfsense-packages#1253
@jim-p

A better test is to use: if (filter_var($url, FILTER_VALIDATE_URL) === false)

Apr 21, 2016
jim-p commented on pull request pfsense/pfsense#2896
@jim-p

There are some instances of dark grey text on dark red that is a bit hard to read, such as the menus and in the footer links. Otherwise looks prett…

Apr 13, 2016
jim-p commented on pull request pfsense/FreeBSD-ports#105
@jim-p

I like the idea of this fix, but I don't like doing a write_config here. Even if it only triggers once, it's not an ideal place. It could assume by…

Apr 7, 2016
jim-p commented on commit pfsense/pfsense@461bae6b08
@jim-p

I see them both on master and RELENG_2_3, and I recall cherry picking both at the time. Where are you not seeing them?

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

See above

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

Seems awkward/wordy. Perhaps "The IPv4 gateway could not be created"

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

Still seems wordy... "The changes must be applied to take effect" gets the point across, or even "The changes must be applied"

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

"The maximum number of wireless clones supported in this mode may have been reached."

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

"The specified IPv6 Prefix ID is out of range"

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

Seems awkward... Perhaps "Only one interface can be configured within a single 6rd prefix" or "An interface already exists using that 6rd prefix" (…

Mar 28, 2016
jim-p commented on pull request pfsense/pfsense#2790
@jim-p

Too many instances of "to" there, and in several places in this commit, should probably be: "The interface must be reassigned to configure as %s"

Mar 22, 2016
jim-p commented on pull request pfsense/pfsense#2777
@jim-p

What advantage does this have over using -s="Subject" which does the exact same thing?

Mar 11, 2016
jim-p commented on pull request pfsense/pfsense#2728
@jim-p

@phil-davis Looks like somehow this already has conflicts, can you check it and rebase?

Mar 11, 2016
jim-p commented on commit pfsense/pfsense@141d8913e2
@jim-p

Yeah, that seems to be a beneficial improvement. We're talking that over on the forum here: https://forum.pfsense.org/index.php?topic=108116.0

Feb 4, 2016
jim-p closed pull request pfsense/pfsense#1552
@jim-p
Support for Radius OTP login and fetching groups from Radius
Feb 4, 2016
jim-p commented on pull request pfsense/pfsense#1552
@jim-p

The code in master has diverged significantly here. We have had support for obtaining groups from the Class reply attribute in place for several mo…

Feb 4, 2016
jim-p commented on pull request pfsense/pfsense#1614
@jim-p

IIRC it was to keep the calculated line length for pf to a sane value. The "weight" is accomplished by repeating the gateway address in the pf line…

Something went wrong with that request. Please try again.