Jim DeLois jimdelois

  • Adobe Systems - Behance Team
  • New York, New York
  • Joined on
jimdelois commented on pull request behance/nbd.php-cache#9
@jimdelois

Shouldn't this be defined in the interface? Ms. Liskov suggests that sub types ought be no more restrictive than their super types...

jimdelois commented on pull request behance/nbd.php-cache#9
@jimdelois

Would it perhaps make sense to create a _bufferDelete( $key ) method so as to encapsulate this implementation logic and prevent the "having to be n…

jimdelois commented on pull request bryanlatten/docker-php#34
@jimdelois

:white_check_mark:

@jimdelois
@jimdelois
@jimdelois
@jimdelois
@jimdelois
@jimdelois
jimdelois created repository jimdelois/raml-generator
jimdelois commented on pull request behance/nbd.php-cache#8
@jimdelois

:white_check_mark:

jimdelois commented on pull request bryanlatten/docker-php#32
@jimdelois

:white_check_mark:

jimdelois commented on pull request behance/nbd.php-cache#7
@jimdelois

LGTM

jimdelois commented on pull request behance/nbd.php-dbal#14
@jimdelois

LGTM

jimdelois commented on pull request behance/nbd.php-validation#24
@jimdelois

:+1:

jimdelois commented on pull request behance/nbd.php-validation#23
@jimdelois

:white_check_mark:

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

:white_check_mark:

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

You could genericize the message to: `throw new RuleRequirementExeption( sprintf( 'A valid ruleset for "%s" must be more than just special rules ("…

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

This doesn't scale at all. If we add special rules (which is now easier to do with your other changes), then one still has to update this stuff... …

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

Careful adding public methods to a service well-defined by an interface...

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

string[]

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

string[]

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

field's

jimdelois commented on pull request behance/nbd.php-validation#21
@jimdelois

This won't necessarily make it to the front-end, but I think it makes sense to keep it here to match the paradigm.