Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_footywire_betting_odds starts some seasons at Round 0 #102

Closed
cfranklin11 opened this issue Dec 19, 2019 · 0 comments
Closed

get_footywire_betting_odds starts some seasons at Round 0 #102

cfranklin11 opened this issue Dec 19, 2019 · 0 comments

Comments

@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Dec 19, 2019

When calling get_footywire_betting_odds() with the full season range (2010 to 2019), seasons 2017 through 2019 start at Round 0 instead of 1 due to a bug in how cumulative round lags are calculated, because the calculations are not properly grouped by season, leading to cumulative lags to leak from one season to the next.

I'm working on a PR with a fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.