Skip to content

/ fitzRoy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounds that span two weeks make subsequent round numbers incorrect #106

Closed
cfranklin11 opened this issue Dec 23, 2019 · 0 comments
Closed

Rounds that span two weeks make subsequent round numbers incorrect #106

cfranklin11 opened this issue Dec 23, 2019 · 0 comments

Comments

@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Dec 23, 2019

Today I learned that 2010 and 2014 each had a round that spanned two weeks. I only noticed this when trying to join Footywire betting data with AFLTables match data. The two-week rounds get split into two rounds and shift all subsequent rounds by one, resulting in an extra round at the end of the season. There's a similar issue with the replayed 2010 Grand Final. I'll open a PR with fixes soon.
@cfranklin11 cfranklin11 mentioned this issue Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix round numbers for seasons with two-week rounds
1 participant
@cfranklin11
You can’t perform that action at this time.