Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_footywire_betting_odds raises error on empty data set #112

Closed
cfranklin11 opened this issue Jan 24, 2020 · 1 comment
Closed

get_footywire_betting_odds raises error on empty data set #112

cfranklin11 opened this issue Jan 24, 2020 · 1 comment

Comments

@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Jan 24, 2020

Requesting betting odds for a season that doesn't have any yet (e.g. 2020 while we're still in January) raises an error from the internals of get_footywire_betting_odds. It would be better for the function to return an empty data frame instead.

I almost have a fix ready, so PR forthcoming.

The code below will raise the error:

fitzRoy::get_footywire_betting_odds(start_season = 2020, end_season = 2020)
@mgpullen
Copy link

@mgpullen mgpullen commented Jul 29, 2020

FYI, running the code in cfranklin11's original post still results in an error even though we are now 8 or so rounds into the season.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.