Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocker Support #13
Docker Support #13
Comments
|
Hi @merbla. Cheers for reaching out! We are open to anything that makes the package better for people. You can probably tell by our code that we are pretty new to this though - can you point us to some info on Docker and what it does? Cheers |
|
Hey @jimmyday12, Sure! For myself Docker or containers sometimes is helpful when you want people to use your software regardless of operating system. It allows them to run Docker as a container service regardless if they are using a different operating system. For example I was not sure if there was a particular operating systems you were thinking of targeting. In my case I run OSX & Windows so depending on what dependencies Fitzroy requires it can be hard to get working on all the Linux variants. Some notes on Docker & containers are below: One other question. Were you thinking of pushing this package to CRAN? |
|
Hi @merbla - thanks for the info. It's not something we'd thought about at all so would be open to a PR to add support. Our initial plan had been to put it on CRAN but since starting, we've realized the structure of the package may have to change a bit for that. Do you have experience submitting to CRAN? |
|
@jimmyday12 never submitted to CRAN myself. Happy to help out where I can. Some more handy links on Docker...
|
|
I've created a docker setup (that builds on each commit via CircleCI) over at this repo. Happy to migrate to this repository so everything lives in one place. Might have to step you through setting up the DockerHub/CircleCI stuff. Thoughts? |
|
Hi mate - awesome to see other people using this! Certainly open to it once I get my head around Docker. I have in the last few weeks setup TravisCI and got that working. Is CircleCI the same thing? Would it work with your setup? |
|
Yep, so CircleCi is similar to TravisCI (Both are build/continuous integration systems) however it might be best to keep Travis for publishing the CRAN/R Package and CircleCI for the Docker image. You could do it all in Travis however the The setup works in a similar way to what you already have, we just add the config into
Currently I have the image publishing as |
|
Hi mate - just got around to looking at this. Happy for you to step me through setting it up as you mentioned above! There has been a couple changes since you implemented it, not sure if that changes much from your end. Let me know the best way to move forward. |
|
Ok, here is a brain dump for what you will need to do:
In short the flow will be:
Ping me when you get the account setup and I can help with a PR if needs be. |
|
Ok great, I setup the accounts
Probably just need a hand with |
Hi,
Great package! Just wondering if you would be interested in PR for Docker support to help on boarding of new users.
Details over at my branch.
Initially setup with
RStudioIf you are keen I would also suggest
Cheers!