Skip to content

/ fitzRoy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Replace Venues' function #15

Closed
jimmyday12 opened this issue Apr 5, 2018 · 3 comments
Closed

Add 'Replace Venues' function #15

jimmyday12 opened this issue Apr 5, 2018 · 3 comments
Assignees
@jimmyday12
Labels
feature

Comments

@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Apr 5, 2018

Footywire venues are named differently to afltables. Write a function people can use to convert them
@jimmyday12 jimmyday12 added the feature label Apr 5, 2018
@jimmyday12 jimmyday12 self-assigned this Apr 5, 2018
@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Sep 23, 2019

If you're not actively working on this, I already have a complete hash map for this that I've been using and would be happy to open a PR.
@jimmyday12
Copy link
Owner Author

@jimmyday12 jimmyday12 commented Oct 16, 2019

Hi @cfranklin11 - sorry I never replied to this but yep, happy for a PR here!
@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Nov 1, 2019

No worries. I noticed that the replace_teams function is applied across all data sources and seems to convert all team names to AFLTables conventions. Did you have something similar in mind for a replace_venues function? I think that's probably the best approach, but wanted to make sure.
@cfranklin11 cfranklin11 mentioned this issue Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmyday12 jimmyday12

Labels
feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add replace_venues function
2 participants
@cfranklin11 @jimmyday12
You can’t perform that action at this time.