Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 Elimination Final is inccorect for Port Adelaide players #28

Closed
jimmyday12 opened this issue Aug 16, 2018 · 0 comments
Closed

2017 Elimination Final is inccorect for Port Adelaide players #28

jimmyday12 opened this issue Aug 16, 2018 · 0 comments
Assignees
Labels
bug

Comments

@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Aug 16, 2018

This is parsing incorrectly for the Port players.

Playing.for is showing the score instead of Port Adelaide

ID is 0 for all players

library(fitzRoy)
library(tidyverse)
dat <- get_afltables_stats()

filter(dat, Season == 2017 & Round == "Elimination Final", Home.team == "West Coast" & Playing.for != "West Coast") %>%
  select(Season, Round, Home.team, Away.team, Playing.for, First.name, Surname, ID) 
#> # A tibble: 22 x 8
#>    Season Round   Home.team Away.team Playing.for First.name Surname    ID
#>     <int> <chr>   <chr>     <chr>     <chr>       <chr>      <chr>   <dbl>
#>  1   2017 Elimin… West Coa… Port Ade… 12.6.78     Karl       Amon        0
#>  2   2017 Elimin… West Coa… Port Ade… 12.6.78     Travis     Boak        0
#>  3   2017 Elimin… West Coa… Port Ade… 12.6.78     Riley      Bonner      0
#>  4   2017 Elimin… West Coa… Port Ade… 12.6.78     Darcy      Byrne-…     0
#>  5   2017 Elimin… West Coa… Port Ade… 12.6.78     Tom        Clurey      0
#>  6   2017 Elimin… West Coa… Port Ade… 12.6.78     Charlie    Dixon       0
#>  7   2017 Elimin… West Coa… Port Ade… 12.6.78     Brad       Ebert       0
#>  8   2017 Elimin… West Coa… Port Ade… 12.6.78     Robbie     Gray        0
#>  9   2017 Elimin… West Coa… Port Ade… 12.6.78     Sam        Gray        0
#> 10   2017 Elimin… West Coa… Port Ade… 12.6.78     Hamish     Hartle…     0
#> # ... with 12 more rows

Created on 2018-08-16 by the reprex
package
(v0.2.0).

@jimmyday12 jimmyday12 added the bug label Aug 16, 2018
@jimmyday12 jimmyday12 self-assigned this Aug 16, 2018
@jimmyday12 jimmyday12 closed this in d778922 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.