Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSuggestion: ungroup the result from get_afltables_stats() #38
Assignees
Comments
|
Thanks @neilfws, I agree. There are a few inconsistencies like that I'd like to fix up. Open to PR if you are interested, otherwise I'll take a look over the next week and keep you posted. |
jimmyday12
added a commit
that referenced
this issue
Oct 1, 2018
fixes #38 output of get_afltables_stats() is no longer grouped
jimmyday12
added a commit
that referenced
this issue
Oct 1, 2018
Merge branch 'master' into develop # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
get_afltables_stats() returns a tibble grouped by Season, Round, Home.team, Away.team.
I would suggest that the function should include
ungroup()as the last step before returning results. It isn't clear to the end user that the output is grouped unless they inspect the tibble, and grouping may have unintended consequences in any code that the user writes which uses the tibble.