Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some player IDs have two versions of names using get_afltables_stats #47

Closed
insightlane opened this issue Oct 7, 2018 · 2 comments
Closed
Assignees
Labels
bug

Comments

@insightlane
Copy link

@insightlane insightlane commented Oct 7, 2018

There are five player IDs that are coming through on get_afltables_stats with two versions of names (e.g. Patrick Ryder/Paddy Ryder):

Brief description of the problem

`n_afltables_data <- get_afltables_stats(start_date = "1897-05-07", end_date = Sys.Date())

n_afltables_data %>%
distinct(ID, First.name, Surname) %>%
group_by(ID) %>%
mutate(count_names = n()) %>%
filter(count_names > 1)`

`# A tibble: 10 x 4

Groups: ID [5]

First.name Surname ID count_names

1 Patrick Ryder 4144 2
2 Matthew de Boer 11746 2
3 Jay Kennedy-Harris 12245 2
4 Darcy MacPherson 12438 2
5 Harrison Himmelberg 12462 2
6 Paddy Ryder 4144 2
7 Jay Kennedy Harris 12245 2
8 Harry Himmelberg 12462 2
9 Matt de Boer 11746 2
10 Darcy Macpherson 12438 2`

@jimmyday12 jimmyday12 self-assigned this Nov 24, 2018
@jimmyday12 jimmyday12 added the bug label Nov 24, 2018
@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Nov 24, 2018

Hmmm thanks for digging into this. I thought I had found all of these but obviously not. I'll keep you posted

@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Jan 19, 2019

Fixed in latest commit ab2ad3c - now return the first instance of a players name even if it changes in the dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.