Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Womens vignette failing travis build #52

Closed
jimmyday12 opened this issue Dec 11, 2018 · 2 comments
Closed

Womens vignette failing travis build #52

jimmyday12 opened this issue Dec 11, 2018 · 2 comments
Labels
bug

Comments

@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Dec 11, 2018

The travis check is failing R CMD CHECK for the womens vignette. The following error message is received

Quitting from lines 35-36 (womens-stats.Rmd) 
Error: processing vignette 'womens-stats.Rmd' failed with diagnostics:
Evaluation error: is.character(x) is not TRUE.

The build passes all checks for me locally and I can knit the vignette fine locally so I'm unsure what is going on. For now, I've prevented the vignette from executing code to see if that helps.

@jimmyday12
Copy link
Owner Author

@jimmyday12 jimmyday12 commented Dec 11, 2018

@OscarLane Just tagging you in as you wrote the vignette so might have some thoughts. I'll see if I can do some digging

@jimmyday12
Copy link
Owner Author

@jimmyday12 jimmyday12 commented Jan 11, 2019

Seemed to have fixed this in the commit a8902ce. Was related to a line of code in get_aflw_round_data() that was using readr::parse_datetime. I've commented that line out and it seems to work. Also has fixes #53!

@jimmyday12 jimmyday12 closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.