Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnfiltered cancelled matches result in NA match dates #56
Assignees
Labels
Comments
|
@cfranklin11 Good pickup - happy for a PR! |
jimmyday12
added a commit
that referenced
this issue
Jan 11, 2019
Resolves #56. Filter cancelled matches out of fixture data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The 2015 fixture has a match in round 14 that was cancelled, resulting in two rows without dates. Given that these are labelled 'MATCH CANCELLED' in the same place where teams' bye rounds are labelled 'BYE', I think it makes sense to add that as a condition to the bye match filter in
get_fixtureto avoid invalid match rows.If the proposed fix sounds good, I'm happy to open a PR to make the change.