Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footywire has changed format #61

Closed
jimmyday12 opened this issue Mar 2, 2019 · 6 comments
Closed

footywire has changed format #61

jimmyday12 opened this issue Mar 2, 2019 · 6 comments
Assignees
Labels
bug

Comments

@jimmyday12
Copy link
Owner

@jimmyday12 jimmyday12 commented Mar 2, 2019

footywire has updated their site and so some of the scrapers are broken.

get_match_data(5000)
 Error: Table has inconsistent number of columns. Do you want fill = TRUE? 
@jimmyday12 jimmyday12 added the bug label Mar 2, 2019
@jimmyday12 jimmyday12 self-assigned this Mar 2, 2019
@jimmyday12 jimmyday12 closed this in ab8aaf6 Mar 3, 2019
@dstatz
Copy link

@dstatz dstatz commented Mar 3, 2019

would this be why the footywire advanced player stats from the 2018 finals isn't coming through?

@jimmyday12
Copy link
Owner Author

@jimmyday12 jimmyday12 commented Mar 3, 2019

Possibly. Are you able to create a new issue on here @dstatz with a reproducible example?

@anoafl
Copy link
Collaborator

@anoafl anoafl commented Mar 4, 2019

fitzRoy::player_stats (only goes to end of home and away 2018)

but if you did

fitzRoy::get_footywire_stats(9720)

That works fine for the grand final

hope that helps @dstatz

@dstatz
Copy link

@dstatz dstatz commented Mar 4, 2019

@jimmyday12 no problem shall do!

@anoafl thanks! I just tried that unfortunately not working for me either :( here's what I got:

> > fitzRoy::get_footywire_stats(9720)
Getting data from footywire.com
Error: Table has inconsistent number of columns. Do you want fill = TRUE?

@anoafl
Copy link
Collaborator

@anoafl anoafl commented Mar 4, 2019

Are you updated with latest Fitzroy?

@dstatz
Copy link

@dstatz dstatz commented Mar 4, 2019

@anoafl yep that was it, updated and the above error was resolved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.