Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up
I came across a few issues with round numbers recently:
For
get_footywire_betting_datathe match on 2018-04-25 is in the wrong round due to the filter matching on date-time and betting data only having dates.Requesting multiple seasons for
get_footywire_betting_dataresults in incorrect round numbers if the request includes 2014, because it started on week 11, whereas the other valid seasons all started on week 12. This makes non-2014 seasons start on round 2 instead of 1.A lot of round numbers are wrong in general largely due to all Sunday matches being off by one (e.g. Sunday matches in round 10 are actually labelled as being in round 11). Given that this worked before, I think it's due to
lubridatechanging how it calculates weekday numbers.