Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some round numbers are incorrect for footywire data sources #93

Closed
cfranklin11 opened this issue Dec 2, 2019 · 0 comments
Closed

Some round numbers are incorrect for footywire data sources #93

cfranklin11 opened this issue Dec 2, 2019 · 0 comments

Comments

@cfranklin11
Copy link
Contributor

@cfranklin11 cfranklin11 commented Dec 2, 2019

I came across a few issues with round numbers recently:

  1. For get_footywire_betting_data the match on 2018-04-25 is in the wrong round due to the filter matching on date-time and betting data only having dates.

  2. Requesting multiple seasons for get_footywire_betting_data results in incorrect round numbers if the request includes 2014, because it started on week 11, whereas the other valid seasons all started on week 12. This makes non-2014 seasons start on round 2 instead of 1.

  3. A lot of round numbers are wrong in general largely due to all Sunday matches being off by one (e.g. Sunday matches in round 10 are actually labelled as being in round 11). Given that this worked before, I think it's due to lubridate changing how it calculates weekday numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.