Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up2019 rounds 5/6 have incorrect matches #95
Closed
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A further refinement of #93
I suspect this is related to the baffling changes in behaviour when calculating
epiweekandwdaythat were addressed in #92. I was trying to recreate previous behaviour, but something has changed. At one point, Wednesday matches were at the start of the new round, which required a manual adjustment of the 2018 ANZAC match. Current behaviour puts Wednesdays at the end of the round, which requires replacing the manual adjustment for 2018 with a similar one for 2019.Looking at the data and the git history, I think the intended behaviour is for Wednesdays to be at the starts of rounds by default, and we leave in the manual fix for 2018, but let me know if it should be otherwise.