Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
implemented creation of zfs bookmarks #342
referenced this pull request
Feb 1, 2019
first remark: I am getting permission denied when doing initial send (no send/recv options used yet) remote to remote - I know, I am the developers pain in the a**, finding all corner cases :)
I will attempt to see if github lets me comment directly on your PR
will comment if/when I discover more
I have one more case :)
Let's have this:
source with one manual snapshot
invoke a second time, and this time (output included in pastebin above too) after "INFO: no snapshots on source newer than firstsync on target. Nothing to do, not syncing.", it attempts to create the bookmark, but it fails because it has the same name.
I was wondering if wether
but then I thought that later in time we can be in the following situation:
So neither recreating nor abandoning creation would be optimal, but creating the bookmark with an additional suffix in the name (for example -$(seconds since midnight padded with zeroes to be a fixed length)-$(random 3 digits) - i could be wrong but that's the first that i imagined EDIT: or first field of cksum coreutils command with the snapshot's guid at input -
Since when searching matching pairs we are comparing guids, this will not affect finding the matching bookmark-snapshot pair, but will allow creating new bookmark even if the snapshot name is the same but taken at different time with a different guid than the original one. I would not delete the bookmark since it might be useful when replicating to a second or third target.
What do you think?
I got this running and it works pretty well - thank you so much!
I've looked at some cases where source and target were linked by just one single common snapshot while each having lots of other snapshots; the sync process sent lots of intermediary snapshots, but the bookmark creation was done only for the newest snapshot.
Is it possible to create bookmarks for each intermediary snapshot that is found to be between oldest snapshot and newest snapshot? This would greatly increase future chances of falling back to a bookmark by having more bookmarks available at source while allowing more aggressive snapshot cleanup on target.
Thank you again and have a great day!